Commit graph

263 commits

Author SHA1 Message Date
GroundedCastle
13e75df196
Updated "To" as a test for making changes 2021-01-12 15:00:50 -06:00
GroundedCastle
e240670a8e
Update README.md 2021-01-11 18:43:56 -06:00
GroundedCastle
f06258377f
Merge pull request #1 from GroundedCastle/GroundedCastle-patch-1
Updated Cogency, Syntax, and Clone Explanation
2021-01-11 18:28:13 -06:00
GroundedCastle
d6977b1f98
Updated Cogency, Syntax, and Clone Explanation
The description said to install "NPM/Node." In the link that's provided, the author says that Node is being installed and specifically states that NPM is not being installed. It's more accurate to just say Node is being installed for now to avoid permission issues. Added colon for a list. Removed first person to create a consistent voice. Explained what cloning was because that's not covered up to this point in Foundations.  Made the capitalization consistent with the rest of the course.
2021-01-11 17:23:34 -06:00
Tatiana
9a40c04726
Merge pull request #121 from vrarora/patch-3
Update Leap Year Definition and grammar
2021-01-10 05:27:41 -08:00
vrarora
6793f8722a
Update Leap Year Definition and grammar
I got confused after seeing the code in solution that definition and solution didn't match so this is what I found on Wikipedia "(except for years evenly divisible by 100, which are not leap years unless evenly divisible by 400)" but earlier it was written here "except for years which are both divisible by 100 and not divisible by 400." 

I maybe wrong here, not knowing that these two statements maybe are indicating two different things, if that's the case, then feel free to not apply the changes and do let me know. 😄 

P.S. - I corrected "effects" to "affects" too.
2020-12-23 17:06:25 +05:30
xandora
d5a2b0ed0a
Merge pull request #120 from vrarora/patch-1
Update helloWorld.js
2020-12-23 07:27:26 +13:00
vrarora
19f6888688
Update helloWorld.js
I added the answer instead of empty strings as solution must be added in the solutions branch.
2020-12-22 14:01:32 +05:30
Briggs Elsperger
7e04012d05
Update README.md 2020-12-09 14:29:25 -08:00
Cody Loyd
e5a4a1d2eb
Update caesar.js
lol i'm dum
2020-11-16 12:25:23 -06:00
Cody Loyd
bde09dacbd
Update caesar.js 2020-11-16 12:24:26 -06:00
Marvin Gay
2c5bb33cfc
Update node installation link 2020-10-28 22:00:21 -04:00
Marvin Gay
5f32e12451
Merge pull request #116 from Abhineet0011/master 2020-10-18 11:26:53 -04:00
Marvin Gay
2563ec716b
Additional revisions to README 2020-10-17 19:43:29 -04:00
Abhineet0011
1c4b1a667e
Update readme.md 2020-10-17 21:20:36 +05:30
Briggs Elsperger
cef55bcfb7
Merge pull request #115 from GraceSchwar/master
Added hint to README.md Instructions
2020-10-16 11:44:43 -06:00
GraceSchwar
7d37e6d67a
Update README.md 2020-10-16 13:44:16 -04:00
GraceSchwar
074b3b7481
Update README.md 2020-10-16 13:26:26 -04:00
Briggs Elsperger
effa0cd70a
Merge pull request #114 from TheOdinProject/I3uckwheat-patch-2
Update repeatString.spec.js
2020-10-14 15:18:32 -06:00
Briggs Elsperger
6e02f72a72
Update repeatString.spec.js 2020-10-14 16:14:33 -05:00
Briggs Elsperger
8eeb98ee71
Merge pull request #113 from mangonaise/patch-1
sumAll solution: check if min/max are integers, not just numbers
2020-10-12 10:38:12 -05:00
liam robertson
2457cb4099
sumAll solution: check if min/max are integers, not just numbers 2020-10-10 19:06:51 +01:00
Cody Loyd
704a0f1826
Merge pull request #81 from Musabii/patch-1
added a test and changed an old one
2020-09-14 10:20:16 -05:00
Cody Loyd
314a795e52
Merge pull request #82 from Musabii/patch-2
changed the order of if conditions
2020-09-14 10:19:40 -05:00
Marvin Gay
4e004bdb1f
Merge pull request #76 from kyriri/patch-1
Further clarify guidelines
2020-09-13 21:14:20 -04:00
Musabii
f9a972ec16
changed the order of if conditions
it flows better logically to first check if the inputs are a number than to check if they are negative.
2020-06-25 11:58:02 +02:00
Musabii
4d82ea16db
added a test and changed an old one
The second test would originally test if it works with upper-case letters and punctuation. but the description of the test is "works with punctuation". I think it is better to either put both in the description or make a new test that solely tests each different thing.
2020-06-25 11:17:48 +02:00
kyriri
da45b701d4
Further clarify guidelines
Everybody in the Southern hemisphere experiences winter in July and that's normal, so the original remark added an unnecessary (and off-topic) layer of confusion.
2020-05-13 20:17:22 -03:00
Briggs Elsperger
888383a44e
Merge pull request #74 from imrogerjiang/new-tests 2020-05-09 12:16:42 -05:00
Roger
5817ea2140 Added blank string test to repeatString 2020-05-08 16:59:37 +10:00
Roger
3758497cb2 Added blank string test to reverseString 2020-05-08 16:56:55 +10:00
Roger
68691ab7a6 Added same type test to removeFromArray 2020-05-08 16:54:31 +10:00
Briggs Elsperger
c0d736a524
Merge pull request #73 from Timework/patch-1 2020-05-02 21:29:46 -05:00
Christopher Martinez
fb5677ee8f
Changed let to const and added some comments.
I changed the let to a const and added some explanation to how the test is conducted in comments included in the test.
2020-05-02 09:04:40 -05:00
Christopher Martinez
312103dc4f
Added random test
I added a random test getting a number from 1 to 1000. You said you wanted comments on it but I was not sure where to put them. I added the global modifier to the recommended regex in order for it count all the words properly.
2020-05-01 12:44:55 -05:00
Briggs Elsperger
26d610ca6e
Update README.md 2020-04-21 14:51:23 -06:00
Briggs Elsperger
9e2e2995e7
Update README.md 2020-04-21 14:51:06 -06:00
Cody Loyd
c61615f4bf
Merge pull request #64 from santimc/patch-1
Delete .DS_Store
2020-02-12 12:58:00 -06:00
Cody Loyd
3b51e5dbef
Update fibonacci.js 2020-01-29 10:52:57 -06:00
santimc
ecc0872e96
Delete .DS_Store 2020-01-09 17:08:41 -03:00
Cody Loyd
f228d73f98
Merge pull request #45 from nearmint/patch-1
Fix typo
2019-11-27 09:18:56 -06:00
Cody Loyd
1d854ec580
Merge pull request #43 from abronkema/removeFromArray-README-update
updates function name to match exercise file
2019-11-27 09:18:12 -06:00
Cody Loyd
66c87fc01b
Merge branch 'master' into removeFromArray-README-update 2019-11-27 09:17:40 -06:00
Cody Loyd
e2f45971a3
Merge pull request #42 from HornMichaelS/master
Fix code indentation on helloWorld README.md
2019-11-27 09:16:30 -06:00
Cody Loyd
24b81e688e
Merge pull request #41 from Uzay-G/patch-1
Added ...rest parameters as a link to deal with optional parameters
2019-11-27 09:16:06 -06:00
Cody Loyd
99e3fa2fd3
Merge pull request #40 from nikolasbroman/patch-1
Fix typo
2019-11-27 09:15:15 -06:00
Cody Loyd
c2ca1d7acc
Merge pull request #36 from chrisjwelly/master
Add more tests for fibonacci
2019-11-27 09:14:33 -06:00
Cody Loyd
abcaeb918a
Merge pull request #35 from seoul2045/solutions
Reduce Method Solution
2019-11-27 09:13:51 -06:00
nearmint
235a6abdc1
Fix typo 2019-09-16 15:12:22 +02:00
Anthony Bronkema
6f30194d16 updates function name to match exercise file 2019-08-19 14:22:59 -04:00