punkfairie/rose-pine-nix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(home-manager): don't let swaylock cause infinite recursion (#243)

Browse source 
i can't begin to describe how i feel right now
This commit is contained in:
seth 2024-06-26 18:27:07 +00:00 committed by GitHub
parent 1adbfeb44a
commit de0dec4cec
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
modules/home-manager/swaylock.nix
View file

@ -2,12 +2,38 @@
let
inherit (config.catppuccin) sources;
cfg = config.programs.swaylock.catppuccin;
enable = cfg.enable && config.programs.swaylock.enable;
in
{
options.programs.swaylock.catppuccin = lib.ctp.mkCatppuccinOpt "swaylock";
options.programs.swaylock.catppuccin = {
enable = lib.mkEnableOption "Catppuccin theme" // {
/*
global `catppuccin.enable` purposefully doesn't work here in configurations with a `home.stateVersion`
that is >= 23.05
config = lib.mkIf enable {
this is because the upstream module will automatically enable itself if `programs.swaylock.settings`
is set in configurations with a `home.stateVersion` that is < 23.05. so, we can't use the
`programs.swaylock.enable` option to guard against defining this like we usually do, as when the
upstream `enable` option is unset on these systems it checks that same `settings` option we would be
defining if *our* and the upstream's `enable` option is `true` ...leading to a case of infinite
recursion where `programs.swaylock.settings` is only being defined if `programs.swaylock.settings` is
defined
debugging this was the most confusing and horrifying thing i've had to deal with throughout working on
this project.
- @getchoo
*/
default = lib.versionAtLeast config.home.stateVersion "23.05" && config.catppuccin.enable;
defaultText = lib.literalExpression ''
`catppuccin.enable` if `home.stateVersion` is >= 23.05, false otherwise
Yes this is weird, and there's a funny story about it in the code comments
'';
};
flavor = lib.ctp.mkFlavorOpt "swaylock";
};
config = lib.mkIf cfg.enable {
programs.swaylock.settings = lib.ctp.fromINI (sources.swaylock + "/themes/${cfg.flavor}.conf");
};
}